From 9e5f6bfa24d5359677faec5c9bd7b75a4ecb2504 Mon Sep 17 00:00:00 2001
From: Rizqi <rizqi@staff.pens.ac.id>
Date: Sat, 27 Jun 2026 02:57:46 +0700
Subject: [PATCH] feat: add batch backup templates and update UI for multi-VM
 job processing

---
 gui_app.py                | 43 ++++++++++++++++++++++++++++++---------
 templates/batch_job.html  | 20 ++++++++++++++++--
 templates/create_job.html | 20 ++++++++++++++++--
 templates/edit_job.html   | 20 ++++++++++++++++--
 4 files changed, 87 insertions(+), 16 deletions(-)

diff --git a/gui_app.py b/gui_app.py
index 0fbf885..443fbea 100644
--- a/gui_app.py
+++ b/gui_app.py
@@ -1179,7 +1179,7 @@ def job_to_display(jid, info):
         'started_fmt':   fmt_time(info.get('started')),
         'dest':          info.get('dest', ''),
         'run_dest':      info.get('run_dest', ''),
-        'replication_dest': info.get('replication_dest', ''),
+        'replication_dest': info.get('replication_dest') or '',
         'compress':      info.get('compress', False),
         'sftp_host':     info.get('sftp_host', ''),
         'schedule_type': info.get('schedule_type', 'now'),
@@ -1439,7 +1439,7 @@ def run_job_thread_impl(jid):
                 
                 # Replicate successful backup if replication_dest is configured
                 rep_dest = info.get('replication_dest')
-                if rep_dest:
+                if rep_dest and str(rep_dest).strip() and str(rep_dest).strip().lower() != 'none':
                     rep_vm_dest = os.path.join(rep_dest, vm, f"backup-{run_timestamp}")
                     replicate_backup_folder(vm_dest, rep_vm_dest, log_path=log_path)
             except Exception as e:
@@ -1467,10 +1467,11 @@ def run_job_thread_impl(jid):
                 enforce_retention_policy(vm_info, log_path=log_path)
                 
                 # Enforce retention policy on replication target if configured
-                if info.get('replication_dest'):
+                rep_dest = info.get('replication_dest')
+                if rep_dest and str(rep_dest).strip() and str(rep_dest).strip().lower() != 'none':
                     rep_vm_info = {
                         'vm_name': vm,
-                        'dest': info['replication_dest'],
+                        'dest': rep_dest,
                         'retention_type': info.get('retention_type', 'keep_all'),
                         'retention_value': info.get('retention_value', 5)
                     }
@@ -1536,7 +1537,7 @@ def run_job_thread_impl(jid):
             
             # Replicate successful backup if replication_dest is configured
             rep_dest = info.get('replication_dest')
-            if rep_dest:
+            if rep_dest and str(rep_dest).strip() and str(rep_dest).strip().lower() != 'none':
                 rep_run_dest = os.path.join(rep_dest, info['vm_name'], f"backup-{run_timestamp}")
                 replicate_backup_folder(run_dest, rep_run_dest, log_path=log_path)
         except Exception as e:
@@ -1552,10 +1553,11 @@ def run_job_thread_impl(jid):
             enforce_retention_policy(info, log_path=log_path)
             
             # Enforce retention policy on replication target if configured
-            if info.get('replication_dest'):
+            rep_dest = info.get('replication_dest')
+            if rep_dest and str(rep_dest).strip() and str(rep_dest).strip().lower() != 'none':
                 rep_info = {
                     'vm_name': info['vm_name'],
-                    'dest': info['replication_dest'],
+                    'dest': rep_dest,
                     'retention_type': info.get('retention_type', 'keep_all'),
                     'retention_value': info.get('retention_value', 5)
                 }
@@ -1879,7 +1881,14 @@ def create_job():
     if request.method == 'POST':
         vm_name          = request.form.get('vm_name', '').strip()
         dest             = request.form.get('dest', './backups').strip()
-        replication_dest = request.form.get('replication_dest', '').strip() or None
+        # Check if replication is enabled
+        enable_replication = 'enable_replication' in request.form
+        if enable_replication:
+            replication_dest = request.form.get('replication_dest', '').strip()
+            if not replication_dest or replication_dest.lower() == 'none':
+                replication_dest = None
+        else:
+            replication_dest = None
         compress         = 'compress' in request.form
         no_verify_ssl    = 'no_verify_ssl' in request.form
         sftp_host        = request.form.get('sftp_host', '').strip() or None
@@ -1996,7 +2005,14 @@ def batch_jobs():
     if request.method == 'POST':
         vm_names         = request.form.getlist('vms')
         dest             = request.form.get('dest', './backups').strip()
-        replication_dest = request.form.get('replication_dest', '').strip() or None
+        # Check if replication is enabled
+        enable_replication = 'enable_replication' in request.form
+        if enable_replication:
+            replication_dest = request.form.get('replication_dest', '').strip()
+            if not replication_dest or replication_dest.lower() == 'none':
+                replication_dest = None
+        else:
+            replication_dest = None
         compress         = 'compress' in request.form
         no_verify_ssl    = 'no_verify_ssl' in request.form
         disk_strategy    = request.form.get('disk_strategy', 'all')
@@ -2375,7 +2391,14 @@ def edit_job(jobid):
 
         if request.method == 'POST':
             dest             = request.form.get('dest', './backups').strip()
-            replication_dest = request.form.get('replication_dest', '').strip() or None
+            # Check if replication is enabled
+            enable_replication = 'enable_replication' in request.form
+            if enable_replication:
+                replication_dest = request.form.get('replication_dest', '').strip()
+                if not replication_dest or replication_dest.lower() == 'none':
+                    replication_dest = None
+            else:
+                replication_dest = None
             compress         = 'compress' in request.form
             no_verify_ssl    = 'no_verify_ssl' in request.form
             schedule_type    = request.form.get('schedule_type', 'now')
diff --git a/templates/batch_job.html b/templates/batch_job.html
index cbb4010..cdcdd3e 100644
--- a/templates/batch_job.html
+++ b/templates/batch_job.html
@@ -243,8 +243,13 @@
             </div>
           </div>
 
-          <div class="form-group">
-            <label class="form-label" for="replication_dest">Replication target path (optional NFS/local)</label>
+          <div class="form-check" style="margin-bottom:15px;">
+            <input type="checkbox" id="enable_replication" name="enable_replication" onchange="toggleReplication()" />
+            <label for="enable_replication">Enable replication to secondary target (NFS/local)</label>
+          </div>
+
+          <div class="form-group" id="replication_section" style="display:none;">
+            <label class="form-label" for="replication_dest">Replication target path</label>
             <input id="replication_dest" class="form-control" type="text" name="replication_dest"
                    placeholder="e.g. /mnt/nfs-backup-replica" />
             <div id="repNfsTargets" style="margin-top:10px; display:none;">
@@ -730,6 +735,17 @@
       weekdayRow.style.display = '';
     }
   }
+
+  function toggleReplication() {
+    const chk = document.getElementById('enable_replication');
+    const sec = document.getElementById('replication_section');
+    if (chk.checked) {
+      sec.style.display = '';
+    } else {
+      sec.style.display = 'none';
+      document.getElementById('replication_dest').value = '';
+    }
+  }
 </script>
 {% endblock %}
 
diff --git a/templates/create_job.html b/templates/create_job.html
index 1605374..210adf6 100644
--- a/templates/create_job.html
+++ b/templates/create_job.html
@@ -236,8 +236,13 @@
                    value="./backups" placeholder="e.g. /mnt/nfs-backup or /data/vmbackups" required />
           </div>
 
-          <div class="form-group">
-            <label class="form-label" for="replication_dest">Replication target path (optional NFS/local)</label>
+          <div class="form-check" style="margin-bottom:15px;">
+            <input type="checkbox" id="enable_replication" name="enable_replication" onchange="toggleReplication()" />
+            <label for="enable_replication">Enable replication to secondary target (NFS/local)</label>
+          </div>
+
+          <div class="form-group" id="replication_section" style="display:none;">
+            <label class="form-label" for="replication_dest">Replication target path</label>
             <input id="replication_dest" class="form-control" type="text" name="replication_dest"
                    placeholder="e.g. /mnt/nfs-backup-replica" />
             <div id="repNfsTargets" style="margin-top:10px; display:none;">
@@ -812,5 +817,16 @@
       weekdayRow.style.display = '';
     }
   }
+
+  function toggleReplication() {
+    const chk = document.getElementById('enable_replication');
+    const sec = document.getElementById('replication_section');
+    if (chk.checked) {
+      sec.style.display = '';
+    } else {
+      sec.style.display = 'none';
+      document.getElementById('replication_dest').value = '';
+    }
+  }
 </script>
 {% endblock %}
diff --git a/templates/edit_job.html b/templates/edit_job.html
index 9db7be0..12ef5fb 100644
--- a/templates/edit_job.html
+++ b/templates/edit_job.html
@@ -230,8 +230,13 @@
             </div>
           </div>
 
-          <div class="form-group">
-            <label class="form-label" for="replication_dest">Replication target path (optional NFS/local)</label>
+          <div class="form-check" style="margin-bottom:15px;">
+            <input type="checkbox" id="enable_replication" name="enable_replication" onchange="toggleReplication()" {% if job.replication_dest %}checked{% endif %} />
+            <label for="enable_replication">Enable replication to secondary target (NFS/local)</label>
+          </div>
+
+          <div class="form-group" id="replication_section" style="{% if not job.replication_dest %}display:none;{% endif %}">
+            <label class="form-label" for="replication_dest">Replication target path</label>
             <input id="replication_dest" class="form-control" type="text" name="replication_dest" value="{{ job.replication_dest }}" placeholder="e.g. /mnt/nfs-backup-replica" />
             
             <div class="nfs-targets" id="repNfsTargets" style="display:none; margin-top: 10px;">
@@ -650,5 +655,16 @@
       weekdayRow.style.display = '';
     }
   }
+
+  function toggleReplication() {
+    const chk = document.getElementById('enable_replication');
+    const sec = document.getElementById('replication_section');
+    if (chk.checked) {
+      sec.style.display = '';
+    } else {
+      sec.style.display = 'none';
+      document.getElementById('replication_dest').value = '';
+    }
+  }
 </script>
 {% endblock %}